What skills can I use to be a good photographer?

First learn how to use the camera on manual and keep it that way . Once you have all the technical parts covered now the creativity kicks in ... if you feel a deep need to creative something beautiful that is one of the signs of a true artist and this may be a good path for you ... your inner creative skills will play a huge part in the kind of work or images you produce. And the best reason someone is good at something besides practicing is if they really enjoy what there doing and it gives them a sense of well-being .

Brandon makes very good points in his answer. I would add, having a passion for photography will take you a long way. Know your equipment; you say that you are practicing a lot and that is a good first step. If you haven't taken a formal course in digital photography, I would recommend seeking one out from a well regarded school. "The Digital Exposure Handbook" by Ross Hoddinott is a very good reference book. Keep in mind, education without practical experience makes it very tough to find work in this or any field. If there are any pros in your area that will take you on as an apprentice or mentor, learning from their experience is very helpful.

Hi Evelyn,
If you're asking what it takes to be a good photographer, I'd say that if photography makes you happy, then you're a good photographer in a very important way, which is expressing yourself creatively.
If you're asking what it takes to be a good artistic photographer, then some of the above ideas will help you train your eye, get a sense of art history, learn technique, composition, etc., all of which are very important. But more important is being able to see the world differently than other people and expressing that through the camera.

If you're asking what it takes to be a successful photographer, it's a given that you can take technically good, well composed, expressive pictures - there are a glut of photographers who can. What will bring success is good communication skills (to speak with clients so you understand their message and can explain your vision), organization skills (so you can get a good workflow, archive your images, bill your clients, etc), and discipline (so you can keep shooting, doing promotions, etc to stay sharp and in the public eye).

I shoot commercial advertising work, which you can see at http://www.davidshopper.com. You have to remember that when I started out, my work probably looked just like yours. It's a journey and you have to let photography take you where it wants.